Metabolomics Society Forum

Software => R => CAMERA => Topic started by: cpudney on March 22, 2012, 10:05:59 PM

Title: Possible bug when groupCorr called with xraw argument
Post by: cpudney on March 22, 2012, 10:05:59 PM
G'day,

When calling groupCorr with the xraw argument set I see the following error message:

Code: [Select]
> groupCorr(object=yanGI, calcIso=TRUE, xraw=xcmsRaw(file))
Start grouping after correlation.
Error in peaks(xa@xcmsSet) :
  error in evaluating the argument 'object' in selecting a method for function 'peaks': Error: object 'xa' not found

Looking at the source code in fct_groupCorr.R it appears the xa has not been assigned a value.

Code: [Select]
  # Check LC information and calcCorr was selected
  if(calcCiS && object@xcmsSet@peaks[1,"rt"] != -1){
    if(!is.null(xraw)) {
      #Use provided xcmsRaw
      maxscans <- length(xraw@scantime)
      scantimes<-list();
      scantimes[[1]] <- xraw@scantime
      pdata <- peaks(xa@xcmsSet)
      EIC <- CAMERA:::getEICs(xraw,pdata,maxscans)

Is this a bug?

Regards,
Chris.
Title: Re: Possible bug when groupCorr called with xraw argument
Post by: Carsten on March 23, 2012, 05:36:12 AM
Hi Chris,

yes, this is indeed a bug.
I fixed it in 1.11.10, which should be available on the BioConductor server tomorrow.

Thanks for pointing this out.

Carsten
Title: Re: Possible bug when groupCorr called with xraw argument
Post by: cpudney on March 27, 2012, 10:13:39 PM
G'day,

Quote
I fixed it in 1.11.10, which should be available on the BioConductor server tomorrow.

It doesn't seem to have appeared (at least update.packages("CAMERA") does nothing, and the CAMERA page (http://http://www.bioconductor.org/packages/release/bioc/html/CAMERA.html) says 1.10.0).

Thanks,
Chris.
Title: Re: Possible bug when groupCorr called with xraw argument
Post by: Ralf on March 27, 2012, 10:59:32 PM
BioC automatically builds packages over night so give it a little more time to show up.
If you need it immediately you can check out a copy through SVN.
Title: Re: Possible bug when groupCorr called with xraw argument
Post by: Carsten on March 28, 2012, 01:45:10 AM
It's now available at http://http://bioconductor.org/packages/2.10/bioc/html/CAMERA.html
Title: Re: Possible bug when groupCorr called with xraw argument
Post by: cpudney on March 29, 2012, 12:03:16 AM
G'day,

Quote
It's now available at http://bioconductor.org/packages/2.10/b ... AMERA.html (http://bioconductor.org/packages/2.10/bioc/html/CAMERA.html)
Thanks - it fixes the problem.

Regards,
Chris.